videosegmentclip: fail to set_caps if problem in caps structure

gst_video_segment_clip_set_caps () should return FALSE if there was a
problem reading the framerate values from the caps structure.

diff --git a/gst/segmentclip/gstvideosegmentclip.c b/gst/segmentclip/gstvideosegmentclip.c
index 7430a65da1665bc807e77f069a29a60d837a9852..0b168e48e778639f9db6915ddf7482e35ca01f50 100644 (file)
--- a/gst/segmentclip/gstvideosegmentclip.c
+++ b/gst/segmentclip/gstvideosegmentclip.c
@@ -167,8 +167,8 @@ gst_video_segment_clip_set_caps (GstSegmentClip * base, GstCaps * caps)
 
   s = gst_caps_get_structure (caps, 0);
 
-  ret = gst_structure_get_fraction (s, "framerate", &fps_n, &fps_d);
-  ret = (fps_d != 0);
+  ret = gst_structure_get_fraction (s, "framerate", &fps_n, &fps_d)
+      && (fps_d != 0);
 
   if (ret) {
     GST_DEBUG_OBJECT (self, "Configured framerate %d/%d", fps_n, fps_d);