media: tuner-xc2028: don't use casts for printing sizes
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 7 Aug 2018 12:10:34 +0000 (08:10 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 8 Aug 2018 14:57:14 +0000 (10:57 -0400)
Makes smatch happier by using %zd instead of casting sizes:
drivers/media/tuners/tuner-xc2028.c:378 load_all_firmwares() warn: argument 4 to %d specifier is cast from pointer
drivers/media/tuners/tuner-xc2028.c:619 load_firmware() warn: argument 6 to %d specifier is cast from pointer

Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/tuners/tuner-xc2028.c

index 222b93e..aa6861d 100644 (file)
@@ -376,9 +376,8 @@ static int load_all_firmwares(struct dvb_frontend *fe,
                        tuner_err("Firmware type ");
                        dump_firm_type(type);
                        printk(KERN_CONT
-                              "(%x), id %llx is corrupted (size=%d, expected %d)\n",
-                              type, (unsigned long long)id,
-                              (unsigned)(endp - p), size);
+                              "(%x), id %llx is corrupted (size=%zd, expected %d)\n",
+                              type, (unsigned long long)id, (endp - p), size);
                        goto corrupt;
                }
 
@@ -616,8 +615,8 @@ static int load_firmware(struct dvb_frontend *fe, unsigned int type,
                }
 
                if ((size + p > endp)) {
-                       tuner_err("missing bytes: need %d, have %d\n",
-                                  size, (int)(endp - p));
+                       tuner_err("missing bytes: need %d, have %zd\n",
+                                  size, (endp - p));
                        return -EINVAL;
                }