[media] s2255drv: Remove redundant NULL test before release_firmware()
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 19:50:04 +0000 (16:50 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 19 Apr 2012 12:09:58 +0000 (09:09 -0300)
release_firmware() tests for NULL pointers on its own - there's no
reason to do an explicit check before calling the function.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/s2255drv.c

index 4894cbb..37845de 100644 (file)
@@ -1826,8 +1826,7 @@ static void s2255_destroy(struct s2255_dev *dev)
                usb_free_urb(dev->fw_data->fw_urb);
                dev->fw_data->fw_urb = NULL;
        }
-       if (dev->fw_data->fw)
-               release_firmware(dev->fw_data->fw);
+       release_firmware(dev->fw_data->fw);
        kfree(dev->fw_data->pfw_data);
        kfree(dev->fw_data);
        /* reset the DSP so firmware can be reloaded next time */