ASoC: Intel: glk_rt5682_max98357a: fix board id mismatch
authorBrent Lu <brent.lu@intel.com>
Mon, 4 Dec 2023 21:41:58 +0000 (15:41 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:33 +0000 (15:35 -0800)
[ Upstream commit 486ede0df82dd74472c6f5651e38ff48f7f766c1 ]

The drv_name in enumeration table for ALC5682I-VS codec does not match
the board id string in machine driver. Modify the entry of "10EC5682"
to enumerate "RTL5682" as well and remove invalid entry.

Fixes: 88b4d77d6035 ("ASoC: Intel: glk_rt5682_max98357a: support ALC5682I-VS codec")
Reported-by: Curtis Malainey <cujomalainey@chromium.org>
Reviewed-by: Curtis Malainey <cujomalainey@chromium.org>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Brent Lu <brent.lu@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20231204214200.203100-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/intel/common/soc-acpi-intel-glk-match.c

index 387e731..8911c90 100644 (file)
@@ -19,6 +19,11 @@ static const struct snd_soc_acpi_codecs glk_codecs = {
        .codecs = {"MX98357A"}
 };
 
+static const struct snd_soc_acpi_codecs glk_rt5682_rt5682s_hp = {
+       .num_codecs = 2,
+       .codecs = {"10EC5682", "RTL5682"},
+};
+
 struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
        {
                .id = "INT343A",
@@ -35,7 +40,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
                .sof_tplg_filename = "sof-glk-da7219.tplg",
        },
        {
-               .id = "10EC5682",
+               .comp_ids = &glk_rt5682_rt5682s_hp,
                .drv_name = "glk_rt5682_mx98357a",
                .fw_filename = "intel/dsp_fw_glk.bin",
                .machine_quirk = snd_soc_acpi_codec_list,
@@ -43,13 +48,6 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
                .sof_tplg_filename = "sof-glk-rt5682.tplg",
        },
        {
-               .id = "RTL5682",
-               .drv_name = "glk_rt5682_max98357a",
-               .machine_quirk = snd_soc_acpi_codec_list,
-               .quirk_data = &glk_codecs,
-               .sof_tplg_filename = "sof-glk-rt5682.tplg",
-       },
-       {
                .id = "10134242",
                .drv_name = "glk_cs4242_mx98357a",
                .fw_filename = "intel/dsp_fw_glk.bin",