drm/amdgpu: release correct lock in amdgpu_gfx_enable_kgq()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 9 May 2023 14:21:14 +0000 (17:21 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 13:36:53 +0000 (09:36 -0400)
This function was releasing the incorrect lock on the error path.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1156e1a60f02 ("drm/amdgpu: add [en/dis]able_kgq() functions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

index a22d88a..87e1a1a 100644 (file)
@@ -644,7 +644,7 @@ int amdgpu_gfx_enable_kgq(struct amdgpu_device *adev, int xcc_id)
                                                adev->gfx.num_gfx_rings);
                if (r) {
                        DRM_ERROR("Failed to lock KIQ (%d).\n", r);
-                       spin_unlock(&adev->gfx.kiq[0].ring_lock);
+                       spin_unlock(&kiq->ring_lock);
                        return r;
                }