Exclude apphost.exe from test shared framework (dotnet/corefx#34496)

* Exclude apphost.exe from test shared framework

We do not need apphost.exe and the 3.0 SDK will actually remove it.
Exclude here so that when building with the 2.x SDK we don't place it in the test shared framework.
This can be removed once we have a new SDK

This is necessary because folks doing a build.cmd use the 2.x SDK when building the product
and get a shared framework with AppHost.exe in it.  Then they do an incremental build with
whatever SDK is on their machine, if it is 3.0 it removes apphost.exe (due to incremental clean)
and then tests fail to run.  Fixes dotnet/corefx#34455

* Simplify some package references

Commit migrated from https://github.com/dotnet/corefx/commit/0c5d35e65254a9a57e4bd6eb59e5e6c7f36d3789

diff --git a/src/libraries/external/runtime/runtime.depproj b/src/libraries/external/runtime/runtime.depproj
index 5759bcf..ba88403 100644 (file)
--- a/src/libraries/external/runtime/runtime.depproj
+++ b/src/libraries/external/runtime/runtime.depproj
@@ -30,26 +30,21 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(TargetsAOT)'!='true'">
-    <PackageReference Include="Microsoft.NETCore.Platforms">
-      <Version>$(MicrosoftNETCorePlatformsPackageVersion)</Version>
-    </PackageReference>
+    <PackageReference Include="Microsoft.NETCore.Platforms" Version="$(MicrosoftNETCorePlatformsPackageVersion)" />
     <PackageReference Include="Microsoft.NETCore.Runtime.CoreCLR">
       <Version>$(MicrosoftNETCoreRuntimeCoreCLRPackageVersion)</Version>
       <!-- Following is version used in release/uwp6.0 -->
       <Version Condition="'$(TargetGroup)'=='uap10.0.16299'">2.1.0-b-uwp6-25707-02</Version>
     </PackageReference>
-    <PackageReference Include="Microsoft.NETCore.TestHost">
-      <Version>$(MicrosoftNETCoreRuntimeCoreCLRPackageVersion)</Version>
-    </PackageReference>
-    <PackageReference Include="runtime.native.System.Data.SqlClient.sni">
-      <Version>$(RuntimeNativeSystemDataSqlClientSniPackageVersion)</Version>
-    </PackageReference>
-    <PackageReference Include="Microsoft.NETCore.DotNetHost">
-      <Version>$(MicrosoftNETCoreDotNetHostPackageVersion)</Version>
-    </PackageReference>
-    <PackageReference Include="Microsoft.NETCore.DotNetHostPolicy">
-      <Version>$(MicrosoftNETCoreDotNetHostPolicyPackageVersion)</Version>
-    </PackageReference>
+    <PackageReference Include="Microsoft.NETCore.TestHost" Version="$(MicrosoftNETCoreRuntimeCoreCLRPackageVersion)" />
+    <PackageReference Include="runtime.native.System.Data.SqlClient.sni" Version="$(RuntimeNativeSystemDataSqlClientSniPackageVersion)" />
+    <PackageReference Include="Microsoft.NETCore.DotNetHost" Version="$(MicrosoftNETCoreDotNetHostPackageVersion)" />
+    <PackageReference Include="Microsoft.NETCore.DotNetHostPolicy" Version="$(MicrosoftNETCoreDotNetHostPolicyPackageVersion)" />
+    <!-- DotNetAppHost is a transitive dependency of DotNetHostPolicy.
+         We do not need apphost.exe and the 3.0 SDK will actually remove it.
+         Exclude here so that when building with the 2.x SDK we don't place it in the test shared framework.
+         This can be removed once we have a new SDK -->
+    <PackageReference Include="Microsoft.NETCore.DotNetAppHost" Version="$(MicrosoftNETCoreDotNetHostPolicyPackageVersion)" ExcludeAssets="All" />
   </ItemGroup>
 
   <ItemGroup>