soundwire: intel: remove useless readl
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 09:11:19 +0000 (17:11 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 30 Mar 2021 06:21:43 +0000 (11:51 +0530)
Cppcheck complains:

drivers/soundwire/intel.c:564:15: style: Variable 'link_control' is
assigned a value that is never used. [unreadVariable]
 link_control = intel_readl(shim, SDW_SHIM_LCTL);

This looks like a leftover from a previous version, remove.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210302091122.13952-9-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/intel.c

index e2e9511..fd95f94 100644 (file)
@@ -561,8 +561,6 @@ static int intel_link_power_down(struct sdw_intel *sdw)
                ret = intel_clear_bit(shim, SDW_SHIM_LCTL, link_control, cpa_mask);
        }
 
-       link_control = intel_readl(shim, SDW_SHIM_LCTL);
-
        mutex_unlock(sdw->link_res->shim_lock);
 
        if (ret < 0) {