iio: imu: st_lsm6dsx: fix edge-trigger interrupts

If we are using edge IRQs, new samples can arrive while processing
current interrupt since there are no hw guarantees the irq line
stays "low" long enough to properly detect the new interrupt.
In this case the new sample will be missed.
Polling FIFO status register in st_lsm6dsx_handler_thread routine
allow us to read new samples even if the interrupt arrives while
processing previous data and the timeslot where the line is "low"
is too short to be properly detected.

Fixes: 89ca88a7cdf2 ("iio: imu: st_lsm6dsx: support active-low interrupts")
Fixes: 290a6ce11d93 ("iio: imu: add support to lsm6dsx driver")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://lore.kernel.org/r/5e93cda7dc1e665f5685c53ad8e9ea71dbae782d.1605378871.git.lorenzo@kernel.org
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index 467214e..7cedaab 100644 (file)
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -2069,19 +2069,35 @@ st_lsm6dsx_report_motion_event(struct st_lsm6dsx_hw *hw)
 static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private)
 {
        struct st_lsm6dsx_hw *hw = private;
+       int fifo_len = 0, len;
        bool event;
-       int count;
 
        event = st_lsm6dsx_report_motion_event(hw);
 
        if (!hw->settings->fifo_ops.read_fifo)
                return event ? IRQ_HANDLED : IRQ_NONE;
 
-       mutex_lock(&hw->fifo_lock);
-       count = hw->settings->fifo_ops.read_fifo(hw);
-       mutex_unlock(&hw->fifo_lock);
+       /*
+        * If we are using edge IRQs, new samples can arrive while
+        * processing current interrupt since there are no hw
+        * guarantees the irq line stays "low" long enough to properly
+        * detect the new interrupt. In this case the new sample will
+        * be missed.
+        * Polling FIFO status register allow us to read new
+        * samples even if the interrupt arrives while processing
+        * previous data and the timeslot where the line is "low" is
+        * too short to be properly detected.
+        */
+       do {
+               mutex_lock(&hw->fifo_lock);
+               len = hw->settings->fifo_ops.read_fifo(hw);
+               mutex_unlock(&hw->fifo_lock);
+
+               if (len > 0)
+                       fifo_len += len;
+       } while (len > 0);
 
-       return count || event ? IRQ_HANDLED : IRQ_NONE;
+       return fifo_len || event ? IRQ_HANDLED : IRQ_NONE;
 }
 
 static int st_lsm6dsx_irq_setup(struct st_lsm6dsx_hw *hw)