xml_dumpers: Return GError when no obj to dump is passed

diff --git a/src/xml_dump_deltapackage.c b/src/xml_dump_deltapackage.c
index 089dc53aaa4b670bd8e99af7821112e8f91be66f..6ace7b52bb5eb0749643b7a0e072dff0d49effb5 100644 (file)
--- a/src/xml_dump_deltapackage.c
+++ b/src/xml_dump_deltapackage.c
@@ -109,8 +109,11 @@ cr_xml_dump_deltapackage(cr_DeltaPackage *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!

diff --git a/src/xml_dump_filelists.c b/src/xml_dump_filelists.c
index 3a4d2375c6169baba475a4e1c586dbec07d5d109..4e8140cff11bd689da8a6d2ca267a4b66b1d2a3b 100644 (file)
--- a/src/xml_dump_filelists.c
+++ b/src/xml_dump_filelists.c
@@ -81,8 +81,11 @@ cr_xml_dump_filelists(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!

diff --git a/src/xml_dump_other.c b/src/xml_dump_other.c
index 4dbd9a7b6472508dc8fce14e9ae09302a7f7a69b..7efc4837118fe7ac9daa20b9c057a30b32d49ab7 100644 (file)
--- a/src/xml_dump_other.c
+++ b/src/xml_dump_other.c
@@ -120,8 +120,11 @@ cr_xml_dump_other(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!

diff --git a/src/xml_dump_primary.c b/src/xml_dump_primary.c
index 960f111d18453f48b05f678b8bc39a88bcfdfa25..5695e0618b5da60047f5401ed2b11eac6182f9fd 100644 (file)
--- a/src/xml_dump_primary.c
+++ b/src/xml_dump_primary.c
@@ -383,9 +383,11 @@ cr_xml_dump_primary(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
-
+    }
 
     // Dump IT!
 

diff --git a/src/xml_dump_repomd.c b/src/xml_dump_repomd.c
index c1b3f7eaf45d35ef231136c383722d25c2314a53..842c5856f83cc317edd0c4d021acb2fa6155403d 100644 (file)
--- a/src/xml_dump_repomd.c
+++ b/src/xml_dump_repomd.c
@@ -215,8 +215,11 @@ cr_xml_dump_repomd(cr_Repomd *repomd, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!repomd)
+    if (!repomd) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No repomd object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!

diff --git a/src/xml_dump_updateinfo.c b/src/xml_dump_updateinfo.c
index fb8753a3a95a0e0e4a3803cc8d183fb032712a02..b9f3b9687f060fffde2242b473394586985b3c10 100644 (file)
--- a/src/xml_dump_updateinfo.c
+++ b/src/xml_dump_updateinfo.c
@@ -207,8 +207,11 @@ cr_xml_dump_updaterecord(cr_UpdateRecord *rec, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!rec)
+    if (!rec) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No updateinfo object to dump specified");
         return NULL;
+    }
 
     // Dump IT!