amt: Fix NULL but dereferenced coccicheck error
authorYang Li <yang.lee@linux.alibaba.com>
Fri, 5 Nov 2021 07:12:50 +0000 (15:12 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Nov 2021 10:45:03 +0000 (10:45 +0000)
Eliminate the following coccicheck warning:
./drivers/net/amt.c:2795:6-9: ERROR: amt is NULL but dereferenced.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/amt.c

index 896c9e2..cfd6c8c 100644 (file)
@@ -2766,7 +2766,7 @@ static int amt_err_lookup(struct sock *sk, struct sk_buff *skb)
        rcu_read_lock_bh();
        amt = rcu_dereference_sk_user_data(sk);
        if (!amt)
-               goto drop;
+               goto out;
 
        if (amt->mode != AMT_MODE_GATEWAY)
                goto drop;
@@ -2788,6 +2788,7 @@ static int amt_err_lookup(struct sock *sk, struct sk_buff *skb)
        default:
                goto drop;
        }
+out:
        rcu_read_unlock_bh();
        return 0;
 drop: