Remove unnecessary fallthrough annotation after unreachable
authorReid Kleckner <rnk@google.com>
Thu, 1 Nov 2018 19:11:05 +0000 (19:11 +0000)
committerReid Kleckner <rnk@google.com>
Thu, 1 Nov 2018 19:11:05 +0000 (19:11 +0000)
Clang's -Wimplicit-fallthrough implementation warns on this. I built
clang with GCC 7.3 in +asserts and -asserts mode, and GCC doesn't warn
on this in either configuration. I think it is unnecessary. I separated
it from the large mechanical patch (https://reviews.llvm.org/D53950) in
case I am wrong and it has to be reverted.

llvm-svn: 345876

llvm/lib/Transforms/Utils/FunctionComparator.cpp

index ef991d7..a717d9b 100644 (file)
@@ -410,8 +410,6 @@ int FunctionComparator::cmpTypes(Type *TyL, Type *TyR) const {
   switch (TyL->getTypeID()) {
   default:
     llvm_unreachable("Unknown type!");
-    // Fall through in Release mode.
-    LLVM_FALLTHROUGH;
   case Type::IntegerTyID:
     return cmpNumbers(cast<IntegerType>(TyL)->getBitWidth(),
                       cast<IntegerType>(TyR)->getBitWidth());