ASoC: SOF: mediatek: mt8195: remove a redundant comparison of sram
authorYC Hung <yc.hung@mediatek.com>
Thu, 15 Dec 2022 06:10:46 +0000 (14:10 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 25 Dec 2022 23:33:24 +0000 (23:33 +0000)
DSP SRAM is not used for audio shared buffer between host and DSP so
TOTAL_SIZE_SHARED_SRAM_FROM_TAIL is zero. Remove the definition and
redundant comparison to fix coverity "unsigned compared against 0".

Signed-off-by: YC Hung <yc.hung@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angeloigoacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221215061046.16934-1-yc.hung@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/mediatek/mt8195/mt8195.c
sound/soc/sof/mediatek/mt8195/mt8195.h

index 3c81e84..7c831e1 100644 (file)
@@ -215,11 +215,6 @@ static int platform_parse_resource(struct platform_device *pdev, void *data)
 
        adsp->pa_sram = (phys_addr_t)mmio->start;
        adsp->sramsize = resource_size(mmio);
-       if (adsp->sramsize < TOTAL_SIZE_SHARED_SRAM_FROM_TAIL) {
-               dev_err(dev, "adsp SRAM(%#x) is not enough for share\n",
-                       adsp->sramsize);
-               return -EINVAL;
-       }
 
        dev_dbg(dev, "sram pbase=%pa,%#x\n", &adsp->pa_sram, adsp->sramsize);
 
index 7ffd523..b422917 100644 (file)
@@ -139,8 +139,6 @@ struct snd_sof_dev;
 #define DSP_MBOX1_BAR  6
 #define DSP_MBOX2_BAR  7
 
-#define TOTAL_SIZE_SHARED_SRAM_FROM_TAIL  0x0
-
 #define SIZE_SHARED_DRAM_DL 0x40000 /*Shared buffer for Downlink*/
 #define SIZE_SHARED_DRAM_UL 0x40000 /*Shared buffer for Uplink*/