media: sunxi-cir: ensure IR is handled when it is continuous
authorSean Young <sean@mess.org>
Mon, 9 Nov 2020 22:16:52 +0000 (23:16 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 25 Nov 2020 13:50:49 +0000 (14:50 +0100)
If a user holds a button down on a remote, then no ir idle interrupt will
be generated until the user releases the button, depending on how quickly
the remote repeats. No IR is processed until that point, which means that
holding down a button may not do anything.

This also resolves an issue on a Cubieboard 1 where the IR receiver is
picking up ambient infrared as IR and spews out endless
"rc rc0: IR event FIFO is full!" messages unless you choose to live in
the dark.

Cc: stable@vger.kernel.org
Tested-by: Hans Verkuil <hverkuil@xs4all.nl>
Acked-by: Maxime Ripard <mripard@kernel.org>
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/rc/sunxi-cir.c

index ddee6ee..4afc589 100644 (file)
@@ -137,6 +137,8 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id)
        } else if (status & REG_RXSTA_RPE) {
                ir_raw_event_set_idle(ir->rc, true);
                ir_raw_event_handle(ir->rc);
+       } else {
+               ir_raw_event_handle(ir->rc);
        }
 
        spin_unlock(&ir->ir_lock);