Fix http2 tests (SettingsFrame does not propagate flags) (dotnet/corefx#38694)
authorKrzysztof Wicher <kwicher@microsoft.com>
Wed, 19 Jun 2019 20:30:05 +0000 (13:30 -0700)
committerDavid Shulman <david.shulman@microsoft.com>
Wed, 19 Jun 2019 20:30:05 +0000 (13:30 -0700)
Commit migrated from https://github.com/dotnet/corefx/commit/37a56121a88d8e67da75e2e5201f2c1c87c7b551

src/libraries/Common/tests/System/Net/Http/Http2Frames.cs

index 11f4309..03f7f2d 100644 (file)
@@ -413,12 +413,17 @@ namespace System.Net.Test.Common
     {
         public List<SettingsEntry> Entries;
 
-        public SettingsFrame(params SettingsEntry[] entries) :
-            base(entries.Length * 6, FrameType.Settings, FrameFlags.None, 0)
+        public SettingsFrame(FrameFlags flags, SettingsEntry[] entries) :
+            base(entries.Length * 6, FrameType.Settings, flags, 0)
         {
             Entries = new List<SettingsEntry>(entries);
         }
 
+        public SettingsFrame(params SettingsEntry[] entries) :
+            this(FrameFlags.None, entries)
+        {
+        }
+
         public static SettingsFrame ReadFrom(Frame header, ReadOnlySpan<byte> buffer)
         {
             var entries = new List<SettingsEntry>();
@@ -433,7 +438,7 @@ namespace System.Net.Test.Common
                 entries.Add(new SettingsEntry { SettingId = id, Value = value });
             }
 
-            return new SettingsFrame(entries.ToArray());
+            return new SettingsFrame(header.Flags, entries.ToArray());
         }
 
         public override void WriteTo(Span<byte> buffer)