ext4: fix inode tree inconsistency caused by ENOMEM
authorzhanchengbin <zhanchengbin1@huawei.com>
Tue, 3 Jan 2023 02:28:12 +0000 (10:28 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 19 Feb 2023 04:58:28 +0000 (23:58 -0500)
If ENOMEM fails when the extent is splitting, we need to restore the length
of the split extent.
In the ext4_split_extent_at function, only in ext4_ext_create_new_leaf will
it alloc memory and change the shape of the extent tree,even if an ENOMEM
is returned at this time, the extent tree is still self-consistent, Just
restore the split extent lens in the function ext4_split_extent_at.

ext4_split_extent_at
 ext4_ext_insert_extent
  ext4_ext_create_new_leaf
   1)ext4_ext_split
     ext4_find_extent
   2)ext4_ext_grow_indepth
     ext4_find_extent

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230103022812.130603-1-zhanchengbin1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 9de1c9d..3559ea6 100644 (file)
@@ -3251,7 +3251,7 @@ static int ext4_split_extent_at(handle_t *handle,
                ext4_ext_mark_unwritten(ex2);
 
        err = ext4_ext_insert_extent(handle, inode, ppath, &newex, flags);
-       if (err != -ENOSPC && err != -EDQUOT)
+       if (err != -ENOSPC && err != -EDQUOT && err != -ENOMEM)
                goto out;
 
        if (EXT4_EXT_MAY_ZEROOUT & split_flag) {