Fix use-after-scope in ASTContext.
authorBenjamin Kramer <benny.kra@googlemail.com>
Wed, 26 Oct 2016 12:51:45 +0000 (12:51 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Wed, 26 Oct 2016 12:51:45 +0000 (12:51 +0000)
Extend lifetime of ExceptionTypeStorage, as it is referenced by
CanonicalEPI and used outside the block (ExceptionSpec.Exceptions is an
ArrayRef)

Patch by Sam McCall!

Differential Revision: https://reviews.llvm.org/D25983

llvm-svn: 285192

clang/lib/AST/ASTContext.cpp

index 9faded7..d2c3585 100644 (file)
@@ -3230,13 +3230,13 @@ QualType ASTContext::getFunctionTypeInternal(
     for (unsigned i = 0; i != NumArgs; ++i)
       CanonicalArgs.push_back(getCanonicalParamType(ArgArray[i]));
 
+    llvm::SmallVector<QualType, 8> ExceptionTypeStorage;
     FunctionProtoType::ExtProtoInfo CanonicalEPI = EPI;
     CanonicalEPI.HasTrailingReturn = false;
 
     if (IsCanonicalExceptionSpec) {
       // Exception spec is already OK.
     } else if (NoexceptInType) {
-      llvm::SmallVector<QualType, 8> ExceptionTypeStorage;
       switch (EPI.ExceptionSpec.Type) {
       case EST_Unparsed: case EST_Unevaluated: case EST_Uninstantiated:
         // We don't know yet. It shouldn't matter what we pick here; no-one