Fix for issue #142 copy_job return value changed from destination job to source job
authorsalimfadhley <sal@stodge.org>
Fri, 5 Jul 2013 23:07:03 +0000 (00:07 +0100)
committersalimfadhley <sal@stodge.org>
Fri, 5 Jul 2013 23:07:03 +0000 (00:07 +0100)
jenkinsapi/jenkins.py
jenkinsapi_tests/systests/test_jenkins.py

index 392bd4047b1c180238ae133db9e6a1985c9578b6..cdea1e8d22f9ef97b6b8d7de3e0ad2d697f282a6 100644 (file)
@@ -145,7 +145,7 @@ class Jenkins(JenkinsBase):
             params=params,
             data='')
         self.poll()
-        return self[jobname]
+        return self[newjobname]
 
     def build_job(self, jobname, params={}):
         """
index af7be3b1eb1d7602d03861abefebcc37510b3361..2f04621ef5ea4e2ac905d730964d047cc1fd194f 100644 (file)
@@ -2,6 +2,7 @@
 System tests for `jenkinsapi.jenkins` module.
 '''
 import unittest
+from jenkinsapi.job import Job
 from jenkinsapi.invocation import Invocation
 from jenkinsapi_tests.systests.base import BaseSystemTest
 from jenkinsapi_tests.systests.job_configs import EMPTY_JOB
@@ -79,9 +80,11 @@ class JobTests(BaseSystemTest):
         copied_job_name = 'CPY%s' % random_string()
 
         self._create_job(template_job_name)
-        self.jenkins.copy_job(template_job_name, copied_job_name)
+        j = self.jenkins.copy_job(template_job_name, copied_job_name)
         self.assertJobIsPresent(template_job_name)
         self.assertJobIsPresent(copied_job_name)
+        self.assertIsInstance(j, Job)
+        self.assertEquals(j.name, copied_job_name)
 
 if __name__ == '__main__':
     unittest.main()