staging/rdma/hfi1: Use BIT_ULL macro
authorJubin John <jubin.john@intel.com>
Mon, 15 Feb 2016 04:20:42 +0000 (20:20 -0800)
committerDoug Ledford <dledford@redhat.com>
Fri, 11 Mar 2016 01:45:38 +0000 (20:45 -0500)
Use BIT_ULL macro to fix checkpatch check:
CHECK: Prefer using the BIT_ULL macro

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/staging/rdma/hfi1/chip.h
drivers/staging/rdma/hfi1/eprom.c
drivers/staging/rdma/hfi1/sdma.h

index 6c581e0..2b30aaa 100644 (file)
 #define TXE_PIO_SEND (TXE + TXE_PIO_SEND_OFFSET)
 
 /* PBC flags */
-#define PBC_INTR               (1ull << 31)
+#define PBC_INTR               BIT_ULL(31)
 #define PBC_DC_INFO_SHIFT      (30)
-#define PBC_DC_INFO            (1ull << PBC_DC_INFO_SHIFT)
-#define PBC_TEST_EBP   (1ull << 29)
-#define PBC_PACKET_BYPASS      (1ull << 28)
-#define PBC_CREDIT_RETURN      (1ull << 25)
-#define PBC_INSERT_BYPASS_ICRC (1ull << 24)
-#define PBC_TEST_BAD_ICRC      (1ull << 23)
-#define PBC_FECN               (1ull << 22)
+#define PBC_DC_INFO            BIT_ULL(PBC_DC_INFO_SHIFT)
+#define PBC_TEST_EBP           BIT_ULL(29)
+#define PBC_PACKET_BYPASS      BIT_ULL(28)
+#define PBC_CREDIT_RETURN      BIT_ULL(25)
+#define PBC_INSERT_BYPASS_ICRC BIT_ULL(24)
+#define PBC_TEST_BAD_ICRC      BIT_ULL(23)
+#define PBC_FECN               BIT_ULL(22)
 
 /* PbcInsertHcrc field settings */
 #define PBC_IHCRC_LKDETH 0x0   /* insert @ local KDETH offset */
index 9a0ddd7..d7250af 100644 (file)
 #define COUNT_DELAY_SEC(n) ((n) * (1000000 / WAIT_SLEEP_US))
 
 /* GPIO pins */
-#define EPROM_WP_N (1ull << 14)        /* EPROM write line */
+#define EPROM_WP_N BIT_ULL(14) /* EPROM write line */
 
 /*
  * Use the EP mutex to guard against other callers from within the driver.
index cc01e81..0ee22c4 100644 (file)
 /*
  * Bits defined in the send DMA descriptor.
  */
-#define SDMA_DESC0_FIRST_DESC_FLAG      (1ULL << 63)
-#define SDMA_DESC0_LAST_DESC_FLAG       (1ULL << 62)
+#define SDMA_DESC0_FIRST_DESC_FLAG      BIT_ULL(63)
+#define SDMA_DESC0_LAST_DESC_FLAG       BIT_ULL(62)
 #define SDMA_DESC0_BYTE_COUNT_SHIFT     48
 #define SDMA_DESC0_BYTE_COUNT_WIDTH     14
 #define SDMA_DESC0_BYTE_COUNT_MASK \
        ((1ULL << SDMA_DESC1_GENERATION_WIDTH) - 1)
 #define SDMA_DESC1_GENERATION_SMASK \
        (SDMA_DESC1_GENERATION_MASK << SDMA_DESC1_GENERATION_SHIFT)
-#define SDMA_DESC1_INT_REQ_FLAG         (1ULL << 1)
-#define SDMA_DESC1_HEAD_TO_HOST_FLAG    (1ULL << 0)
+#define SDMA_DESC1_INT_REQ_FLAG         BIT_ULL(1)
+#define SDMA_DESC1_HEAD_TO_HOST_FLAG    BIT_ULL(0)
 
 enum sdma_states {
        sdma_state_s00_hw_down,