colibri_t20: fix ulpi reset polarity
authorMarcel Ziswiler <marcel.ziswiler@toradex.com>
Mon, 19 Dec 2016 14:38:07 +0000 (15:38 +0100)
committerTom Warren <twarren@nvidia.com>
Tue, 3 Jan 2017 17:34:13 +0000 (10:34 -0700)
Fix ULPI reset polarity which caused a hard hang on Colibri T20 upon
attempting to start the USB subsystem:

This fixes my late commit d5a24d8b53d350364bd429b7104ec369b817e4b8
(colibri_t20: fix usb operation and controller order) inadvertently
having overwritten Stephen's previous commit
2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04 (ARM: tegra: fix USB ULPI PHY
reset signal inversion confusion).

While at it also fix comment about on-module USB port.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: Tom Warren <twarren@nvidia.com>
arch/arm/dts/tegra20-colibri.dts

index 89adfb6..3c10dd6 100644 (file)
@@ -16,7 +16,7 @@
                i2c2 = "/i2c@7000c400";
                mmc0 = "/sdhci@c8000600";
                usb0 = "/usb@c5000000";
-               usb1 = "/usb@c5004000"; /* on-module only, for ASIX */
+               usb1 = "/usb@c5004000"; /* On-module only, for ASIX */
                usb2 = "/usb@c5008000";
        };
 
        /* EHCI instance 1: ULPI -> USB3340 -> AX88772B */
        usb@c5004000 {
                status = "okay";
+               /* ULPI_RESET */
+               nvidia,phy-reset-gpio =
+                               <&gpio TEGRA_GPIO(V, 1) GPIO_ACTIVE_LOW>;
                /* VBUS_LAN */
-               nvidia,phy-reset-gpio = <&gpio TEGRA_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
                nvidia,vbus-gpio = <&gpio TEGRA_GPIO(BB, 1) GPIO_ACTIVE_HIGH>;
        };