cli-command: Report error in pa_play_file.
authorTomaz Solc <tomaz.solc@tablix.org>
Tue, 29 May 2018 07:22:59 +0000 (09:22 +0200)
committerArun Raghavan <arun@arunraghavan.net>
Thu, 21 Jun 2018 01:00:25 +0000 (06:30 +0530)
Current code does not check whether pa_play_file call failed. Hence no error is
reported in the cli interface if playback failed because e.g. file isn't
readable by the daemon.

src/pulsecore/cli-command.c

index 44795b0..defdac1 100644 (file)
@@ -1282,7 +1282,12 @@ static int pa_cli_command_play_file(pa_core *c, pa_tokenizer *t, pa_strbuf *buf,
         return -1;
     }
 
-    return pa_play_file(sink, fname, NULL);
+    if (pa_play_file(sink, fname, NULL) < 0) {
+        pa_strbuf_puts(buf, "Failed to play sound file.\n");
+        return -1;
+    }
+
+    return 0;
 }
 
 static int pa_cli_command_list_shared_props(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, bool *fail) {