zink: move blend_operation_advanced conditions to zink_device_info.py
authorHoe Hao Cheng <haochengho12907@gmail.com>
Tue, 24 Nov 2020 17:56:56 +0000 (01:56 +0800)
committerMarge Bot <eric+marge@anholt.net>
Thu, 10 Dec 2020 12:40:59 +0000 (12:40 +0000)
Acked-by: Adam Jackson <ajax@redhat.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7756>

src/gallium/drivers/zink/zink_device_info.py
src/gallium/drivers/zink/zink_screen.c

index cbe5544..ffd0afc 100644 (file)
@@ -96,7 +96,9 @@ def EXTENSIONS():
             conditions=["$feats.customBorderColors"]),
         Extension("VK_EXT_blend_operation_advanced",
             alias="blend",
-            properties=True),
+            properties=True,
+            # TODO: we can probably support non-premul here with some work?
+            conditions=["$props.advancedBlendNonPremultipliedSrcColor", "$props.advancedBlendNonPremultipliedDstColor"]),
         Extension("VK_EXT_extended_dynamic_state",
             alias="dynamic_state",
             features=True,
index 796319d..68938f1 100644 (file)
@@ -1132,11 +1132,6 @@ zink_internal_create_screen(struct sw_winsys *winsys, int fd, const struct pipe_
    qci.queueCount = 1;
    qci.pQueuePriorities = &dummy;
 
-   /* TODO: we can probably support non-premul here with some work? */
-   screen->info.have_EXT_blend_operation_advanced = screen->info.have_EXT_blend_operation_advanced &&
-                                                    screen->info.blend_props.advancedBlendNonPremultipliedSrcColor &&
-                                                    screen->info.blend_props.advancedBlendNonPremultipliedDstColor;
-
    VkDeviceCreateInfo dci = {};
    dci.sType = VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO;
    dci.queueCreateInfoCount = 1;