tag: id3v2: On second thought, it might be wiser and more efficient not to do tag...

Original commit message from CVS:
* gst-libs/gst/tag/gstid3demux.c: (plugin_init):
* gst-libs/gst/tag/id3v2.c:
(id3demux_add_id3v2_frame_blob_to_taglist):
* gst-libs/gst/tag/id3v2.h:
On second thought, it might be wiser and more efficient
not to do tag registration from a streaming thread.

diff --git a/gst-libs/gst/tag/id3v2.c b/gst-libs/gst/tag/id3v2.c
index a34964c..6af215d 100644 (file)
--- a/gst-libs/gst/tag/id3v2.c
+++ b/gst-libs/gst/tag/id3v2.c
@@ -330,8 +330,6 @@ convert_fid_to_v240 (gchar * frame_id)
 }
 
 
-#define GST_ID3_DEMUX_TAG_ID3V2_FRAME "private-id3v2-frame"
-
 /* add unknown or unhandled ID3v2 frames to the taglist as binary blobs */
 static void
 id3demux_add_id3v2_frame_blob_to_taglist (ID3TagsWorking * work, guint size)
@@ -342,11 +340,6 @@ id3demux_add_id3v2_frame_blob_to_taglist (ID3TagsWorking * work, guint size)
   gchar *media_type;
   guint frame_size;
 
-  /* ensure private tag is registered */
-  gst_tag_register (GST_ID3_DEMUX_TAG_ID3V2_FRAME, GST_TAG_FLAG_META,
-      GST_TYPE_BUFFER, "ID3v2 frame", "unparsed id3v2 tag frame",
-      gst_tag_merge_use_first);
-
   frame_data = work->hdr.frame_data - ID3V2_HDR_SIZE;
   frame_size = size + ID3V2_HDR_SIZE;
 

diff --git a/gst-libs/gst/tag/id3v2.h b/gst-libs/gst/tag/id3v2.h
index cdf165d..c87c871 100644 (file)
--- a/gst-libs/gst/tag/id3v2.h
+++ b/gst-libs/gst/tag/id3v2.h
@@ -23,6 +23,9 @@
 
 G_BEGIN_DECLS
 
+/* private tag for storing unprocessed ID3v2 frames */
+#define GST_ID3_DEMUX_TAG_ID3V2_FRAME "private-id3v2-frame"
+
 #define ID3V1_TAG_SIZE 128
 #define ID3V2_MARK_SIZE 3
 #define ID3V2_HDR_SIZE 10