queue: add unit test

Make a downstream element return an error after upstream has already
put all data into queue (including EOS).  As such, upstream
will not be around to pick up the error, so it is up to queue to
act appropriately.  See #589991.

Note there may be downstream fatal errors (e.g. negotiation) that do
not warrant an error message already having been posted.

diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am
index ef25ab0..4c32289 100644 (file)
--- a/tests/check/Makefile.am
+++ b/tests/check/Makefile.am
@@ -70,7 +70,8 @@ REGISTRY_CHECKS =                             \
        libs/basesrc                            \
        libs/controller                         \
        libs/typefindhelper                     \
-       pipelines/stress
+       pipelines/stress                        \
+       pipelines/queue-error
 endif
 
 check_PROGRAMS =                               \

diff --git a/tests/check/pipelines/queue-error.c b/tests/check/pipelines/queue-error.c
new file mode 100644 (file)
index 0000000..b43e085
--- /dev/null
+++ b/tests/check/pipelines/queue-error.c
@@ -0,0 +1,109 @@
+/* GStreamer unit test for queue
+ *
+ * Copyright (C) 2007 Tim-Philipp Müller  <tim centricular net>
+ * Copyright (C) 2009 Mark Nauwelaerts  <mnauw users sourceforge net>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ * Boston, MA 02111-1307, USA.
+ */
+
+#include <gst/check/gstcheck.h>
+
+#include <gst/gst.h>
+
+static gboolean
+modify_caps (GstObject * pad, GstEvent * event, gpointer data)
+{
+  GstElement *filter = GST_ELEMENT (data);
+  GstCaps *caps;
+
+  fail_unless (event != NULL);
+  fail_unless (GST_IS_EVENT (event));
+
+  if (GST_EVENT_TYPE (event) != GST_EVENT_EOS)
+    return TRUE;
+
+  /* trigger caps negotiation error */
+  caps = gst_caps_new_simple ("video/x-raw-rgb", NULL);
+  g_object_set (filter, "caps", caps, NULL);
+  gst_caps_unref (caps);
+
+  return TRUE;
+}
+
+GST_START_TEST (test_queue)
+{
+  GstStateChangeReturn state_ret;
+  GstMessage *msg;
+  GstElement *pipeline, *filter, *queue;
+  GstBus *bus;
+  GstPad *pad;
+  guint probe;
+  gchar *pipe_desc =
+      g_strdup_printf ("fakesrc num-buffers=1 ! video/x-raw-yuv ! "
+      "queue min-threshold-buffers=2 name=queue ! "
+      "capsfilter name=nasty ! fakesink");
+
+  pipeline = gst_parse_launch (pipe_desc, NULL);
+  fail_unless (pipeline != NULL);
+  g_free (pipe_desc);
+
+  filter = gst_bin_get_by_name (GST_BIN (pipeline), "nasty");
+  fail_unless (filter != NULL);
+
+  /* queue waits for all data and EOS to arrive */
+  /* then probe forces downstream element to return negotiation error */
+  queue = gst_bin_get_by_name (GST_BIN (pipeline), "queue");
+  fail_unless (queue != NULL);
+  pad = gst_element_get_static_pad (queue, "sink");
+  fail_unless (pad != NULL);
+  probe = gst_pad_add_event_probe (pad, G_CALLBACK (modify_caps), filter);
+
+  bus = gst_element_get_bus (pipeline);
+
+  state_ret = gst_element_set_state (pipeline, GST_STATE_PLAYING);
+  fail_unless (state_ret != GST_STATE_CHANGE_FAILURE);
+
+  msg = gst_bus_poll (bus, GST_MESSAGE_ERROR | GST_MESSAGE_EOS, 5 * GST_SECOND);
+  fail_unless (msg != NULL, "timeout waiting for error or eos message");;
+
+  gst_message_unref (msg);
+  gst_object_unref (bus);
+
+  fail_unless_equals_int (gst_element_set_state (pipeline, GST_STATE_NULL),
+      GST_STATE_CHANGE_SUCCESS);
+
+  gst_pad_remove_event_probe (pad, probe);
+  gst_object_unref (queue);
+  gst_object_unref (pad);
+  gst_object_unref (filter);
+  gst_object_unref (pipeline);
+}
+
+GST_END_TEST;
+
+static Suite *
+queue_suite (void)
+{
+  Suite *s = suite_create ("queue");
+  TCase *tc_chain = tcase_create ("general");
+
+  suite_add_tcase (s, tc_chain);
+  tcase_add_test (tc_chain, test_queue);
+
+  return s;
+}
+
+GST_CHECK_MAIN (queue)