eet: add NULL-check to eet_connection_empty API to avoid segfault
authorArtem Popov <artem.popov@samsung.com>
Wed, 16 Nov 2016 23:30:29 +0000 (15:30 -0800)
committerWonki Kim <wonki_.kim@samsung.com>
Mon, 2 Jan 2017 07:23:55 +0000 (16:23 +0900)
@fix

Summary:
Only eet_connection_empty hasn't checking on NULL and try to read from field of object.
Add NULL-check for connection and return result of empty connection.

Reviewers: jpeg, cedric, myoungwoon

Subscribers: t.naumenko, NikaWhite

Differential Revision: https://phab.enlightenment.org/D4399

Change-Id: Ia080d4bb4b38a61377381977a159cb0e260055ea
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
src/lib/eet/eet_connection.c
src/lib/eet/eet_data.c

index 7945692..735e112 100644 (file)
@@ -157,6 +157,7 @@ _eet_connection_raw_send(Eet_Connection *conn,
 EAPI Eina_Bool
 eet_connection_empty(Eet_Connection *conn)
 {
+   EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_TRUE);
    return conn->size ? EINA_FALSE : EINA_TRUE;
 }
 
index 1c42393..02be40b 100644 (file)
@@ -5273,6 +5273,7 @@ eet_data_descriptor_encode_cipher(Eet_Data_Descriptor *edd,
    int size;
 
    EINA_SAFETY_ON_NULL_RETURN_VAL(edd, NULL);
+   EINA_SAFETY_ON_NULL_RETURN_VAL(data_in, NULL);
 
    ret = _eet_data_descriptor_encode(NULL, edd, data_in, &size);
    if (cipher_key && ret)