pata_imx: Propagate the real error code on platform_get_irq() failure
authorFabio Estevam <fabio.estevam@freescale.com>
Mon, 17 Feb 2014 22:05:57 +0000 (19:05 -0300)
committerTejun Heo <tj@kernel.org>
Tue, 18 Feb 2014 22:39:54 +0000 (17:39 -0500)
No need to return a 'fake' return value on platform_get_irq() failure.

Just return the error code itself instead.

Also, change the error condition to irq < 0, so that only negative values
are treated as errors.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/pata_imx.c

index 50e2cf2..121c748 100644 (file)
@@ -100,8 +100,8 @@ static int pata_imx_probe(struct platform_device *pdev)
        int ret;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0)
-               return -EINVAL;
+       if (irq < 0)
+               return irq;
 
        priv = devm_kzalloc(&pdev->dev,
                                sizeof(struct pata_imx_priv), GFP_KERNEL);