isci: Manage the IREQ_NO_AUTO_FREE_TAG under scic_lock.

Since there is a possibilty of a timeout waiting for the RNC suspension,
handle the exit case from the task termination under scic_lock, and leave
the tag allocated if the termination timed-out.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

diff --git a/drivers/scsi/isci/remote_device.c b/drivers/scsi/isci/remote_device.c
index 48765aa..a3a6487 100644 (file)
--- a/drivers/scsi/isci/remote_device.c
+++ b/drivers/scsi/isci/remote_device.c
@@ -243,8 +243,11 @@ enum sci_status isci_remote_device_terminate_requests(
                                         idev->rnc.destination_state,
                                         ireq, ireq->flags);
                        }
+                       spin_lock_irqsave(&ihost->scic_lock, flags);
                        clear_bit(IREQ_NO_AUTO_FREE_TAG, &ireq->flags);
-                       isci_free_tag(ihost, ireq->io_tag);
+                       if (!test_bit(IREQ_ABORT_PATH_ACTIVE, &ireq->flags))
+                               isci_free_tag(ihost, ireq->io_tag);
+                       spin_unlock_irqrestore(&ihost->scic_lock, flags);
                } else {
                        /* Terminate all TCs. */
                        sci_remote_device_terminate_requests(idev);