cifs: log warning message (once) if out of disk space
authorSteve French <stfrench@microsoft.com>
Wed, 5 Feb 2020 22:52:11 +0000 (16:52 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:34:53 +0000 (08:34 +0100)
[ Upstream commit d6fd41905ec577851734623fb905b1763801f5ef ]

We ran into a confusing problem where an application wasn't checking
return code on close and so user didn't realize that the application
ran out of disk space.  log a warning message (once) in these
cases. For example:

  [ 8407.391909] Out of space writing to \\oleg-server\small-share

Signed-off-by: Steve French <stfrench@microsoft.com>
Reported-by: Oleg Kravtsov <oleg@tuxera.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/smb2pdu.c

index 0d4e4d9..e2d2b74 100644 (file)
@@ -3425,6 +3425,9 @@ smb2_writev_callback(struct mid_q_entry *mid)
                                     wdata->cfile->fid.persistent_fid,
                                     tcon->tid, tcon->ses->Suid, wdata->offset,
                                     wdata->bytes, wdata->result);
+               if (wdata->result == -ENOSPC)
+                       printk_once(KERN_WARNING "Out of space writing to %s\n",
+                                   tcon->treeName);
        } else
                trace_smb3_write_done(0 /* no xid */,
                                      wdata->cfile->fid.persistent_fid,