[llvm][TextAPI/MachO] Support writing single macCatalyst platform
authorJonas Devlieghere <jonas@devlieghere.com>
Mon, 27 Jan 2020 18:17:46 +0000 (10:17 -0800)
committerJonas Devlieghere <jonas@devlieghere.com>
Mon, 27 Jan 2020 18:21:06 +0000 (10:21 -0800)
TAPI currently lacks a way to emit the macCatalyst platform. For TBD_V3
is does support zippered frameworks given that both macOS and
macCatalyst are part of the PlatformSet.

Differential revision: https://reviews.llvm.org/D73325

llvm/lib/TextAPI/MachO/TextStubCommon.cpp
llvm/unittests/TextAPI/TextStubV3Tests.cpp

index 183c5d5..a7fd58f 100644 (file)
@@ -74,6 +74,9 @@ void ScalarTraits<PlatformSet>::output(const PlatformSet &Values, void *IO,
   case PlatformKind::bridgeOS:
     OS << "bridgeos";
     break;
+  case PlatformKind::macCatalyst:
+    OS << "iosmac";
+    break;
   }
 }
 
index 6d27700..4a05920 100644 (file)
@@ -329,15 +329,11 @@ TEST(TBDv3, Platform_macCatalyst) {
   EXPECT_EQ(FileType::TBD_V3, File->getFileType());
   EXPECT_EQ(Platform, *File->getPlatforms().begin());
 
-  // It's not currently possible to emit the iomac platform. Enable this once
-  // that's fixed.
-#if 0
   SmallString<4096> Buffer;
   raw_svector_ostream OS(Buffer);
   auto WriteResult = TextAPIWriter::writeToStream(OS, *File);
   EXPECT_TRUE(!WriteResult);
   EXPECT_EQ(stripWhitespace(tbd_v3_platform_iosmac), stripWhitespace(Buffer.c_str()));
-#endif
 }
 
 TEST(TBDv3, Platform_zippered) {