ASoC: tas2562: Propagate the error in tas2562_dac_event()
authorFabio Estevam <festevam@denx.de>
Tue, 13 Sep 2022 23:17:06 +0000 (20:17 -0300)
committerMark Brown <broonie@kernel.org>
Wed, 14 Sep 2022 09:39:27 +0000 (10:39 +0100)
Since commit 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute") the
following build warning is seen:

sound/soc/codecs/tas2562.c:442:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]

Fix the warning by returning the 'ret' variable.

Fixes: 2848d34c3ba1 ("ASoC: tas2562: Fix mute/unmute")
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Martin PoviĊĦer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20220913231706.516849-1-festevam@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2562.c

index 6614905..b486d0b 100644 (file)
@@ -439,7 +439,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w,
        struct snd_soc_component *component =
                                        snd_soc_dapm_to_component(w->dapm);
        struct tas2562_data *tas2562 = snd_soc_component_get_drvdata(component);
-       int ret;
+       int ret = 0;
 
        switch (event) {
        case SND_SOC_DAPM_POST_PMU:
@@ -455,7 +455,7 @@ static int tas2562_dac_event(struct snd_soc_dapm_widget *w,
                return -EINVAL;
        }
 
-       return 0;
+       return ret;
 }
 
 static int tas2562_volume_control_get(struct snd_kcontrol *kcontrol,