s390/cert_store: fix error return code in fill_cs_keyring()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 28 Jul 2023 08:42:28 +0000 (16:42 +0800)
committerHeiko Carstens <hca@linux.ibm.com>
Sat, 29 Jul 2023 12:57:19 +0000 (14:57 +0200)
The 'rc' will be re-assigned to 0 after calling get_vcssb(), it
needs be set to error code if create_cs_keyring() fails.

[hca@linux.ibm.com: slightly changed coding style]
Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230728084228.3186083-1-yangyingliang@huawei.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/kernel/cert_store.c

index 1cbeb9c..3986a04 100644 (file)
@@ -702,6 +702,7 @@ static int fill_cs_keyring(void)
        if (rc)
                goto cleanup_keys;
 
+       rc = -ENOMEM;
        cs_keyring = create_cs_keyring();
        if (!cs_keyring)
                goto cleanup_keys;