Fix coverity issue - Missing unlock 90/244090/1 accepted/tizen/unified/20200916.121749 submit/tizen/20200915.034715
authorJeongmo Yang <jm80.yang@samsung.com>
Tue, 15 Sep 2020 03:23:09 +0000 (12:23 +0900)
committerJeongmo Yang <jm80.yang@samsung.com>
Tue, 15 Sep 2020 03:23:09 +0000 (12:23 +0900)
[Version] 0.1.20
[Issue Type] Coverity

Change-Id: I9a5377d9d8d268a00730f8d0c6be54eada011dc4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
packaging/capi-media-tool.spec
src/media_packet_pool.c

index a8bda2857998783d1d00a3b4ced05273d7770b21..c3412a8d93ff5abd200ea7a7247ba0ae4269f00d 100755 (executable)
@@ -1,6 +1,6 @@
 Name:       capi-media-tool
 Summary:    A Core API media tool library in Tizen Native API
-Version:    0.1.19
+Version:    0.1.20
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index b97e184c1a203b5fae493343c4b30d34155fa7b5..c2b25c7c7e514ec1605f0c7db39ac26397ca66dc 100644 (file)
@@ -222,6 +222,7 @@ int media_packet_pool_acquire_packet(media_packet_pool_h pool, media_packet_h *p
 
                        if (media_packet_create_alloc(pool_handle->fmt_h, _packet_finalize_cb, pool_handle, &pool_handle->packet[pool_handle->curr_pool_size]) != MEDIA_PACKET_ERROR_NONE) {
                                LOGE("The media packet pool is full or out of memory...");
+                               g_mutex_unlock(&pool_handle->mutex);
                                return MEDIA_PACKET_ERROR_INVALID_OPERATION;
                        }
                        packet = pool_handle->packet[pool_handle->curr_pool_size];
@@ -339,6 +340,7 @@ int media_packet_pool_deallocate(media_packet_pool_h pool)
 
                packet = g_queue_pop_head(pool_handle->queue);
                if (packet == NULL) {
+                       g_mutex_unlock(&pool_handle->mutex);
                        LOGE("Failed to get packet handle from Queue ");        //LCOV_EXCL_LINE
                        return MEDIA_PACKET_ERROR_INVALID_OPERATION;
                }