redenc: fix setting of extension ID for twcc
authorMathieu Duponchelle <mathieu@centricular.com>
Tue, 24 Jan 2023 21:50:37 +0000 (22:50 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 26 Jan 2023 18:34:09 +0000 (18:34 +0000)
1 was previously hardcoded in, and the bug went under the radar because
webrtcsink hardcodes the number too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3812>

subprojects/gst-plugins-good/gst/rtp/gstrtpredenc.c

index 7f234bc..94062fe 100644 (file)
@@ -200,8 +200,8 @@ _alloc_red_packet_and_fill_headers (GstRtpRedEnc * self,
      * for our wrapper */
     if (gst_rtp_buffer_get_extension_onebyte_header (inp_rtp, self->twcc_ext_id,
             0, &inp_data, &inp_size)) {
-      gst_rtp_buffer_add_extension_onebyte_header (&red_rtp, 1, &data,
-          sizeof (guint16));
+      gst_rtp_buffer_add_extension_onebyte_header (&red_rtp, self->twcc_ext_id,
+          &data, sizeof (guint16));
     } else if (gst_rtp_buffer_get_extension_twobytes_header (inp_rtp, &appbits,
             self->twcc_ext_id, 0, &inp_data, &inp_size)) {
       gst_rtp_buffer_add_extension_twobytes_header (&red_rtp, appbits,