rpmsg: glink: Avoid infinite loop on intent for missing channel
authorBjorn Andersson <quic_bjorande@quicinc.com>
Tue, 14 Feb 2023 23:42:31 +0000 (15:42 -0800)
committerBjorn Andersson <andersson@kernel.org>
Wed, 15 Feb 2023 04:28:55 +0000 (20:28 -0800)
In the event that an intent advertisement arrives on an unknown channel
the fifo is not advanced, resulting in the same message being handled
over and over.

Fixes: dacbb35e930f ("rpmsg: glink: Receive and store the remote intent buffers")
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Chris Lew <quic_clew@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230214234231.2069751-1-quic_bjorande@quicinc.com
drivers/rpmsg/qcom_glink_native.c

index 89c3381f06c331a841b924597d5e855f7162f14b..b6c60bf86009b5f7b0b77d955294e1b2af12466e 100644 (file)
@@ -966,6 +966,7 @@ static void qcom_glink_handle_intent(struct qcom_glink *glink,
        spin_unlock_irqrestore(&glink->idr_lock, flags);
        if (!channel) {
                dev_err(glink->dev, "intents for non-existing channel\n");
+               qcom_glink_rx_advance(glink, ALIGN(msglen, 8));
                return;
        }