llvmpipe/fs: fix regression in sample mask handling from tgsi removal.
authorDave Airlie <airlied@redhat.com>
Tue, 26 Sep 2023 02:43:37 +0000 (12:43 +1000)
committerMarge Bot <emma+marge@anholt.net>
Tue, 26 Sep 2023 20:15:22 +0000 (20:15 +0000)
This got the bits the wrong way,
dEQP-VK.rasterization.frag_side_effects.color_at_beginning.sample_mask_after

Fixes: a63c2daf7ad7 ("llvmpipe/fs: start using nir info in some places.")
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25396>

src/gallium/drivers/llvmpipe/lp_state_fs.c
src/virtio/ci/venus-fails.txt

index b644a9d..b380f4c 100644 (file)
@@ -3782,7 +3782,7 @@ generate_variant(struct llvmpipe_context *lp,
          !key->blend.alpha_to_coverage &&
          !key->depth.enabled &&
          !nir->info.fs.uses_discard &&
-         (nir->info.outputs_written & BITFIELD64_BIT(FRAG_RESULT_SAMPLE_MASK)) &&
+         !(nir->info.outputs_written & BITFIELD64_BIT(FRAG_RESULT_SAMPLE_MASK)) &&
          !nir->info.fs.uses_fbfetch_output;
 
    variant->opaque =
index 6bb57c4..1ccf418 100644 (file)
@@ -1,3 +1,2 @@
 # New CTS failures in 1.3.6.3
 dEQP-VK.api.info.image_format_properties.2d.linear.g8_b8r8_2plane_420_unorm,Fail
-dEQP-VK.rasterization.frag_side_effects.color_at_beginning.sample_mask_after,Fail