selftests/bpf: Report program name on parse_test_spec error
authorEduard Zingerman <eddyz87@gmail.com>
Sat, 25 Mar 2023 02:54:42 +0000 (04:54 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Sun, 26 Mar 2023 00:02:02 +0000 (17:02 -0700)
Change test_loader.c:run_subtest() behavior to show BPF program name
when test spec for that program can't be parsed.

Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20230325025524.144043-2-eddyz87@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_loader.c

index bf41390..8ca5121 100644 (file)
@@ -232,8 +232,11 @@ void run_subtest(struct test_loader *tester,
 
                /* if we can't derive test specification, go to the next test */
                err = parse_test_spec(tester, obj, prog, &spec);
-               if (!ASSERT_OK(err, "parse_test_spec"))
+               if (err) {
+                       PRINT_FAIL("Can't parse test spec for program '%s'\n",
+                                  bpf_program__name(prog));
                        continue;
+               }
 
                tobj = bpf_object__open_mem(obj_bytes, obj_byte_cnt, &open_opts);
                if (!ASSERT_OK_PTR(tobj, "obj_open_mem")) /* shouldn't happen */