crypto: arm/sha512-neon - Fix clang function cast warnings
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 19 Apr 2023 09:34:30 +0000 (17:34 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 May 2023 10:48:01 +0000 (18:48 +0800)
Instead of casting the function which upsets clang for some reason,
change the assembly function siganture instead.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304081828.zjGcFUyE-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm/crypto/sha512-neon-glue.c

index c879ad3..c6e58fe 100644 (file)
@@ -20,8 +20,8 @@
 MODULE_ALIAS_CRYPTO("sha384-neon");
 MODULE_ALIAS_CRYPTO("sha512-neon");
 
-asmlinkage void sha512_block_data_order_neon(u64 *state, u8 const *src,
-                                            int blocks);
+asmlinkage void sha512_block_data_order_neon(struct sha512_state *state,
+                                            const u8 *src, int blocks);
 
 static int sha512_neon_update(struct shash_desc *desc, const u8 *data,
                              unsigned int len)
@@ -33,8 +33,7 @@ static int sha512_neon_update(struct shash_desc *desc, const u8 *data,
                return sha512_arm_update(desc, data, len);
 
        kernel_neon_begin();
-       sha512_base_do_update(desc, data, len,
-               (sha512_block_fn *)sha512_block_data_order_neon);
+       sha512_base_do_update(desc, data, len, sha512_block_data_order_neon);
        kernel_neon_end();
 
        return 0;
@@ -49,9 +48,8 @@ static int sha512_neon_finup(struct shash_desc *desc, const u8 *data,
        kernel_neon_begin();
        if (len)
                sha512_base_do_update(desc, data, len,
-                       (sha512_block_fn *)sha512_block_data_order_neon);
-       sha512_base_do_finalize(desc,
-               (sha512_block_fn *)sha512_block_data_order_neon);
+                                     sha512_block_data_order_neon);
+       sha512_base_do_finalize(desc, sha512_block_data_order_neon);
        kernel_neon_end();
 
        return sha512_base_finish(desc, out);