RDMA/cxgb3: remove redundant first assignement of sqp
authorColin Ian King <colin.king@canonical.com>
Mon, 11 Sep 2017 11:42:31 +0000 (12:42 +0100)
committerDoug Ledford <dledford@redhat.com>
Wed, 27 Sep 2017 12:54:19 +0000 (08:54 -0400)
sqp is being initialised when it is being declared and then updated
a little later on making the first initialization redundant. Clean
this up by initializing ptr and sqp at their declaration.

Cleans up warning: "warning: Value stored to 'sqp' during its
initialization is never read"

Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as needed on flush")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/cxgb3/cxio_hal.c

index 3eff654..3328acc 100644 (file)
@@ -404,12 +404,10 @@ static void insert_sq_cqe(struct t3_wq *wq, struct t3_cq *cq,
 
 int cxio_flush_sq(struct t3_wq *wq, struct t3_cq *cq, int count)
 {
-       __u32 ptr;
+       __u32 ptr = wq->sq_rptr + count;
        int flushed = 0;
-       struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(wq->sq_rptr, wq->sq_size_log2);
+       struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);
 
-       ptr = wq->sq_rptr + count;
-       sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);
        while (ptr != wq->sq_wptr) {
                sqp->signaled = 0;
                insert_sq_cqe(wq, cq, sqp);