Fixed coding styles in TestBase.java of RE-android
authorcoderhyme <jhyo.kim@samsung.com>
Mon, 14 Mar 2016 12:28:23 +0000 (05:28 -0700)
committerJungHo Kim <jhyo.kim@samsung.com>
Thu, 24 Mar 2016 04:01:21 +0000 (04:01 +0000)
Change-Id: I5cd88b6ee6c20312bc12d6c4082cbe046af5b13b
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
service/resource-encapsulation/android/service/src/androidTest/java/org/iotivity/service/TestBase.java [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 9882002..1b78bd7
@@ -25,11 +25,12 @@ public abstract class TestBase extends InstrumentationTestCase {
     private OnResourceDiscoveredListener mOnResourceDiscoveredListener = new OnResourceDiscoveredListener() {
         @Override
         public void onResourceDiscovered(
-                RcsRemoteResourceObject RcsRemoteResourceObject) {
-            if (mClient != null)
+                RcsRemoteResourceObject remoteObject) {
+            if (mClient != null) {
                 return;
+            }
 
-            mClient = RcsRemoteResourceObject;
+            mClient = remoteObject;
             synchronized (mCond) {
                 mCond.notify();
             }
@@ -53,8 +54,7 @@ public abstract class TestBase extends InstrumentationTestCase {
         while (mClient == null) {
             try {
                 RcsDiscoveryManager.DiscoveryTask discoveryTask = RcsDiscoveryManager
-                        .getInstance().discoverResourceByType(
-                                RcsAddress.multicast(), "/oic/res",
+                        .getInstance().discoverResourceByType(RcsAddress.multicast(),
                                 RESOURCETYPE, mOnResourceDiscoveredListener);
 
                 synchronized (mCond) {
@@ -71,9 +71,13 @@ public abstract class TestBase extends InstrumentationTestCase {
     protected void setServerAttrbutes(RcsResourceAttributes attrs)
             throws RcsException {
         RcsResourceObject.AttributesLock lock = mServer.getAttributesLock();
-        lock.lock().putAll(attrs);
-        lock.apply();
-        lock.unlock();
+
+        try {
+            lock.lock().putAll(attrs);
+            lock.apply();
+        } finally {
+            lock.unlock();
+        }
     }
 
     @Override