hwrng: ba431 - Use device-managed registration
authorTian Tao <tiantao6@hisilicon.com>
Tue, 9 Feb 2021 01:35:34 +0000 (09:35 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 7 Mar 2021 04:13:14 +0000 (15:13 +1100)
Use device-managed registration, so we can delete the ba431_trng_remove.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/ba431-rng.c

index 410b50b..4f514e2 100644 (file)
@@ -193,7 +193,7 @@ static int ba431_trng_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, ba431);
 
-       ret = hwrng_register(&ba431->rng);
+       ret = devm_hwrng_register(&pdev->dev, &ba431->rng);
        if (ret) {
                dev_err(&pdev->dev, "BA431 registration failed (%d)\n", ret);
                return ret;
@@ -204,15 +204,6 @@ static int ba431_trng_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int ba431_trng_remove(struct platform_device *pdev)
-{
-       struct ba431_trng *ba431 = platform_get_drvdata(pdev);
-
-       hwrng_unregister(&ba431->rng);
-
-       return 0;
-}
-
 static const struct of_device_id ba431_trng_dt_ids[] = {
        { .compatible = "silex-insight,ba431-rng", .data = NULL },
        { /* sentinel */ }
@@ -225,7 +216,6 @@ static struct platform_driver ba431_trng_driver = {
                .of_match_table = ba431_trng_dt_ids,
        },
        .probe = ba431_trng_probe,
-       .remove = ba431_trng_remove,
 };
 
 module_platform_driver(ba431_trng_driver);