memory: fsl_ifc: populate child devices without relying on simple-bus
authorLi Yang <leoyang.li@nxp.com>
Tue, 16 Nov 2021 21:18:46 +0000 (15:18 -0600)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thu, 27 Jan 2022 09:41:23 +0000 (10:41 +0100)
After we update the binding to not use simple-bus compatible for the
controller, we need the driver to populate the child devices explicitly.

Signed-off-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20211116211846.16335-3-leoyang.li@nxp.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
drivers/memory/fsl_ifc.c

index 75a8c38..2f6939d 100644 (file)
@@ -88,6 +88,7 @@ static int fsl_ifc_ctrl_remove(struct platform_device *dev)
 {
        struct fsl_ifc_ctrl *ctrl = dev_get_drvdata(&dev->dev);
 
+       of_platform_depopulate(&dev->dev);
        free_irq(ctrl->nand_irq, ctrl);
        free_irq(ctrl->irq, ctrl);
 
@@ -285,8 +286,16 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev)
                }
        }
 
+       /* legacy dts may still use "simple-bus" compatible */
+       ret = of_platform_populate(dev->dev.of_node, NULL, NULL,
+                                       &dev->dev);
+       if (ret)
+               goto err_free_nandirq;
+
        return 0;
 
+err_free_nandirq:
+       free_irq(fsl_ifc_ctrl_dev->nand_irq, fsl_ifc_ctrl_dev);
 err_free_irq:
        free_irq(fsl_ifc_ctrl_dev->irq, fsl_ifc_ctrl_dev);
 err_unmap_nandirq: