dgram: change Socket.bind() to return itself

This commit changes `lib/dgram.js` Sockets to, when
they are bound to a port / IP, return themselves. This
is done in order to allow chaining of methods and be
in accordance with the `lib/net.js` library.

PR-URL: https://github.com/iojs/io.js/pull/214
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

diff --git a/lib/dgram.js b/lib/dgram.js
index defa144bd1deec54044ca1f5947100504276793f..6b1772e6128dba410fc09cec7d8b69d2a632854e 100644 (file)
--- a/lib/dgram.js
+++ b/lib/dgram.js
@@ -170,7 +170,7 @@ Socket.prototype.bind = function(port /*, address, callback*/) {
   if (port instanceof UDP) {
     replaceHandle(self, port);
     startListening(self);
-    return;
+    return self;
   }
 
   var address;
@@ -231,6 +231,8 @@ Socket.prototype.bind = function(port /*, address, callback*/) {
       startListening(self);
     }
   });
+
+  return self;
 };
 
 

diff --git a/test/parallel/test-dgram-bind.js b/test/parallel/test-dgram-bind.js
index 8ee67637fcb6ce90aea75afbe7b4f6a52131bd02..1fe615bb75791650c49e7e9f8c242758a2a60d20 100644 (file)
--- a/test/parallel/test-dgram-bind.js
+++ b/test/parallel/test-dgram-bind.js
@@ -29,4 +29,6 @@ socket.on('listening', function () {
   socket.close();
 });
 
-socket.bind(); // should not throw
+var result = socket.bind(); // should not throw
+
+assert.strictEqual(result, socket); // should have returned itself