IB/mlx5: Enable DEVX on IB
authorYishai Hadas <yishaih@mellanox.com>
Thu, 20 Sep 2018 18:45:21 +0000 (21:45 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 27 Sep 2018 19:01:33 +0000 (13:01 -0600)
IB has additional protections with SELinux that cannot be extended to the
DEVX domain. SELinux can restrict access to pkeys. The first version of
DEVX blocked IB entirely until this could be understood.

Since DEVX requires CAP_NET_RAW, it supersedes the SELinux restriction and
allows userspace to form arbitrary packets with arbitrary pkeys.

Thus we enable IB for DEVX when CAP_NET_RAW is given.

Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/main.c

index 10e5992..b3294a7 100644 (file)
@@ -1759,12 +1759,6 @@ static struct ib_ucontext *mlx5_ib_alloc_ucontext(struct ib_device *ibdev,
 #endif
 
        if (req.flags & MLX5_IB_ALLOC_UCTX_DEVX) {
-               /* Block DEVX on Infiniband as of SELinux */
-               if (mlx5_ib_port_link_layer(ibdev, 1) != IB_LINK_LAYER_ETHERNET) {
-                       err = -EPERM;
-                       goto out_uars;
-               }
-
                err = mlx5_ib_devx_create(dev);
                if (err < 0)
                        goto out_uars;