Double free removed in calendar dbus 06/216806/1
authorkamaljeet chauhan <kamal.jc@samsung.com>
Fri, 1 Nov 2019 09:10:38 +0000 (14:40 +0530)
committerkamaljeet chauhan <kamal.jc@samsung.com>
Fri, 1 Nov 2019 09:10:38 +0000 (14:40 +0530)
Change-Id: Ieffff0204e84d3261e83bfa08555688cfeae6e3a
Signed-off-by: kamaljeet chauhan <kamal.jc@samsung.com>
client/cal_client_dbus.c

index a15025b..30fb0a4 100644 (file)
@@ -310,9 +310,6 @@ int cal_dbus_insert_record(calendar_h handle, calendar_record_h record, int *out
        if (out_id)
                *out_id = id;
 
-       g_variant_unref(arg_record);
-       g_variant_unref(arg_handle);
-
        CAL_LIMIT_ACCESS_BACK;
        return ret;
 }
@@ -348,8 +345,6 @@ int cal_dbus_update_record(calendar_h handle, calendar_record_h record)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_record);
-       g_variant_unref(arg_handle);
 
        CAL_LIMIT_ACCESS_BACK;
        return ret;
@@ -385,7 +380,6 @@ int cal_dbus_delete_record(calendar_h handle, const char *view_uri, int id)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_handle);
        CAL_LIMIT_ACCESS_BACK;
        return ret;
 }
@@ -422,9 +416,6 @@ int cal_dbus_replace_record(calendar_h handle, calendar_record_h record, int id)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_record);
-       g_variant_unref(arg_handle);
-
        CAL_LIMIT_ACCESS_BACK;
        return ret;
 }
@@ -474,10 +465,6 @@ int cal_dbus_insert_records(calendar_h handle, calendar_list_h list,
        if (out_count)
                *out_count = count;
 
-       g_variant_unref(arg_list);
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_ids);
-
        return ret;
 }
 
@@ -510,9 +497,6 @@ int cal_dbus_update_records(calendar_h handle, calendar_list_h list)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_list);
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -547,9 +531,6 @@ int cal_dbus_delete_records(calendar_h handle, const char *view_uri, int *ids, i
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_ids);
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -586,10 +567,6 @@ int cal_dbus_replace_records(calendar_h handle, calendar_list_h list, int *ids,
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_list);
-       g_variant_unref(arg_ids);
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -624,9 +601,6 @@ int cal_dbus_get_record(calendar_h handle, const char *view_uri, int id,
        }
        cal_dbus_utils_gvariant_to_record(arg_record, out_record);
 
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_record);
-
        return ret;
 }
 
@@ -662,9 +636,6 @@ int cal_dbus_get_all_records(calendar_h handle, const char *view_uri,
        if (*out_list)
                calendar_list_first(*out_list);
 
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_list);
-
        return ret;
 }
 
@@ -700,8 +671,6 @@ int cal_dbus_get_records_with_query(calendar_h handle, calendar_query_h query,
        if (*out_list)
                calendar_list_first(*out_list);
 
-       g_variant_unref(arg_list);
-
        return ret;
 }
 
@@ -732,7 +701,6 @@ int cal_dbus_get_count(calendar_h handle, const char *view_uri, int *out_count)
        }
        *out_count = count;
 
-       g_variant_unref(arg_handle);
        return ret;
 }
 
@@ -765,9 +733,6 @@ int cal_dbus_get_count_with_query(calendar_h handle, calendar_query_h query, int
        }
        *out_count = count;
 
-       g_variant_unref(arg_query);
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -908,9 +873,6 @@ int cal_dbus_get_changes_by_version(calendar_h handle, const char *view_uri,
        if (*out_list)
                calendar_list_first(*out_list);
 
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_list);
-
        return ret;
 }
 
@@ -949,9 +911,6 @@ int cal_dbus_get_changes_exception_by_version(calendar_h handle, const char *vie
        if (*out_list)
                calendar_list_first(*out_list);
 
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_list);
-
        return ret;
 }
 
@@ -979,8 +938,6 @@ int cal_dbus_clean_after_sync(calendar_h handle, int book_id, int version)
                /* LCOV_EXCL_STOP */
        }
 
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -1027,9 +984,6 @@ int cal_dbus_insert_vcalendars(calendar_h handle, const char *stream,
        if (out_count)
                *out_count = count;
 
-       g_variant_unref(arg_handle);
-       g_variant_unref(arg_ids);
-
        return ret;
 }
 
@@ -1065,9 +1019,6 @@ int cal_dbus_replace_vcalendars(calendar_h handle, const char *stream,
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_ids);
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -1098,8 +1049,6 @@ int cal_dbus_link_record(calendar_h handle, int base_id, int record_id)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_handle);
-
        return ret;
 }
 
@@ -1129,8 +1078,6 @@ int cal_dbus_unlink_record(calendar_h handle, int record_id)
        }
        cal_client_handle_set_version(handle, version);
 
-       g_variant_unref(arg_handle);
-
        return ret;
 }