iio: chemical: bme680: use FIELD_GET macro
authorDavid Frey <dpfrey@gmail.com>
Fri, 17 Aug 2018 19:03:18 +0000 (12:03 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 19 Aug 2018 16:08:25 +0000 (17:08 +0100)
Use the FIELD_GET macro instead of explicit mask and shift.

Signed-off-by: David Frey <dpfrey@gmail.com>
Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>
Tested-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/bme680_core.c

index 0ebe2d2..ced63e3 100644 (file)
@@ -285,7 +285,7 @@ static int bme680_read_calib(struct bme680_data *data,
                dev_err(dev, "failed to read resistance heat range\n");
                return ret;
        }
-       calib->res_heat_range = (tmp & BME680_RHRANGE_MASK) / 16;
+       calib->res_heat_range = FIELD_GET(BME680_RHRANGE_MASK, tmp);
 
        ret = regmap_read(data->regmap, BME680_REG_RES_HEAT_VAL, &tmp);
        if (ret < 0) {
@@ -299,7 +299,7 @@ static int bme680_read_calib(struct bme680_data *data,
                dev_err(dev, "failed to read range software error\n");
                return ret;
        }
-       calib->range_sw_err = (tmp & BME680_RSERROR_MASK) / 16;
+       calib->range_sw_err = FIELD_GET(BME680_RSERROR_MASK, tmp);
 
        return 0;
 }