staging: rtl8723bs: put constant on the right side in if condition
authorFabio Aiuto <fabioaiuto83@gmail.com>
Wed, 7 Apr 2021 13:49:32 +0000 (15:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Apr 2021 15:13:03 +0000 (17:13 +0200)
fix the following post-commit hook checkpatch warning:

WARNING: Comparisons should place the constant on the right side of the test
683: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2204:
+ if (_SUCCESS != rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1))

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/41c98d13d5c74b1329ae125f097b780745cf8246.1617802415.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c

index 2392eb2..2f65162 100644 (file)
@@ -2199,7 +2199,7 @@ static int rtw_wx_set_channel_plan(struct net_device *dev,
        struct adapter *padapter = rtw_netdev_priv(dev);
        u8 channel_plan_req = (u8)(*((int *)wrqu));
 
-       if (_SUCCESS != rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1))
+       if (rtw_set_chplan_cmd(padapter, channel_plan_req, 1, 1) != _SUCCESS)
                return -EPERM;
 
        return 0;