playbin3: fix missing lock when unknown stream type in pad-removed cb
authorhoonhee.lee <hoonhee.lee@lge.com>
Fri, 15 Apr 2022 05:03:08 +0000 (14:03 +0900)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Sat, 16 Apr 2022 01:31:18 +0000 (01:31 +0000)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2193>

subprojects/gst-plugins-base/gst/playback/gstplaybin3.c

index 7946c6a..d7089bd 100644 (file)
@@ -3143,11 +3143,12 @@ pad_removed_cb (GstElement * decodebin, GstPad * pad, GstSourceGroup * group)
   else if (g_str_has_prefix (GST_PAD_NAME (pad), "text"))
     combine = &playbin->combiner[PLAYBIN_STREAM_TEXT];
   else
-    return;
+    goto done;
 
   combiner_release_pad (playbin, combine, pad);
   release_source_pad (playbin, group, pad);
 
+done:
   GST_PLAY_BIN3_UNLOCK (playbin);
 }