net: dsa: ksz: Check return value
authorArtem Chernyshev <artem.chernyshev@red-soft.ru>
Thu, 1 Dec 2022 14:00:30 +0000 (17:00 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 3 Dec 2022 04:46:51 +0000 (20:46 -0800)
Return NULL if we got unexpected value from skb_trim_rcsum()
in ksz_common_rcv()

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: bafe9ba7d908 ("net: dsa: ksz: Factor out common tag code")
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20221201140032.26746-1-artem.chernyshev@red-soft.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_ksz.c

index 38fa19c..4292502 100644 (file)
@@ -21,7 +21,8 @@ static struct sk_buff *ksz_common_rcv(struct sk_buff *skb,
        if (!skb->dev)
                return NULL;
 
-       pskb_trim_rcsum(skb, skb->len - len);
+       if (pskb_trim_rcsum(skb, skb->len - len))
+               return NULL;
 
        dsa_default_offload_fwd_mark(skb);