projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0791721
)
PCI/ERR: Avoid negated conditional for clarity
author
Sean V Kelley
<sean.v.kelley@intel.com>
Sat, 21 Nov 2020 00:10:29 +0000
(16:10 -0800)
committer
Bjorn Helgaas
<bhelgaas@google.com>
Fri, 4 Dec 2020 17:18:58 +0000
(11:18 -0600)
Reverse the sense of the Root Port/Downstream Port conditional for clarity.
No functional change intended.
Link:
https://lore.kernel.org/r/20201121001036.8560-9-sean.v.kelley@intel.com
Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # non-native/no RCEC
Signed-off-by: Sean V Kelley <sean.v.kelley@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/pci/pcie/err.c
patch
|
blob
|
history
diff --git
a/drivers/pci/pcie/err.c
b/drivers/pci/pcie/err.c
index
46a5b84
..
931e75f
100644
(file)
--- a/
drivers/pci/pcie/err.c
+++ b/
drivers/pci/pcie/err.c
@@
-159,11
+159,11
@@
pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
* Error recovery runs on all subordinates of the bridge. If the
* bridge detected the error, it is cleared at the end.
*/
- if (!(type == PCI_EXP_TYPE_ROOT_PORT ||
- type == PCI_EXP_TYPE_DOWNSTREAM))
- bridge = pci_upstream_bridge(dev);
- else
+ if (type == PCI_EXP_TYPE_ROOT_PORT ||
+ type == PCI_EXP_TYPE_DOWNSTREAM)
bridge = dev;
+ else
+ bridge = pci_upstream_bridge(dev);
bus = bridge->subordinate;
pci_dbg(bridge, "broadcast error_detected message\n");