ocfs2: checking the wrong variable in ocfs2_move_extent()
authorDan Carpenter <error27@gmail.com>
Sun, 29 May 2011 19:56:31 +0000 (22:56 +0300)
committerJoel Becker <jlbec@evilplan.org>
Wed, 1 Jun 2011 02:03:44 +0000 (19:03 -0700)
"new_phys_cpos" is always a valid pointer here.
ocfs2_probe_alloc_group() allocates "*new_phys_cpos".

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Joel Becker <jlbec@evilplan.org>
fs/ocfs2/move_extents.c

index cd94270..d3433d6 100644 (file)
@@ -746,7 +746,7 @@ static int ocfs2_move_extent(struct ocfs2_move_extents_context *context,
         */
        ocfs2_probe_alloc_group(inode, gd_bh, &goal_bit, len, move_max_hop,
                                new_phys_cpos);
-       if (!new_phys_cpos) {
+       if (!*new_phys_cpos) {
                ret = -ENOSPC;
                goto out_commit;
        }