mtd: spi-nor: fix silent truncation in spi_nor_read_raw()
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Wed, 30 Oct 2019 18:53:03 +0000 (21:53 +0300)
committerTudor Ambarus <tudor.ambarus@microchip.com>
Sat, 2 Nov 2019 10:16:38 +0000 (12:16 +0200)
spi_nor_read_raw() assigns the result of 'ssize_t spi_nor_read_data()'
to the 'int ret' variable, while 'ssize_t' is a 64-bit type and *int*
is a 32-bit type on the 64-bit machines. This silent truncation isn't
really valid, so fix up the variable's type.

Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
drivers/mtd/spi-nor/spi-nor.c

index e1b1d38..f896200 100644 (file)
@@ -2866,7 +2866,7 @@ static int spi_nor_hwcaps_pp2cmd(u32 hwcaps)
  */
 static int spi_nor_read_raw(struct spi_nor *nor, u32 addr, size_t len, u8 *buf)
 {
-       int ret;
+       ssize_t ret;
 
        while (len) {
                ret = spi_nor_read_data(nor, addr, len, buf);